Post Syndicated from original https://mjg59.dreamwidth.org/61232.html

Being able to SSH into remote machines and do work there is great. Using hardware security tokens for 2FA is also great. But trying to use them both at the same time doesn’t work super well, because if you hit a WebAuthn request on the remote machine it doesn’t matter how much you mash your token – it’s not going to work.

But could it?

The SSH agent protocol abstracts key management out of SSH itself and into a separate process. When you run “ssh-add .ssh/id_rsa”, that key is being loaded into the SSH agent. When SSH wants to use that key to authenticate to a remote system, it asks the SSH agent to perform the cryptographic signatures on its behalf. SSH also supports forwarding the SSH agent protocol over SSH itself, so if you SSH into a remote system then remote clients can also access your keys – this allows you to bounce through one remote system into another without having to copy your keys to those remote systems.

More recently, SSH gained the ability to store SSH keys on hardware tokens such as Yubikeys. If configured appropriately, this means that even if you forward your agent to a remote site, that site can’t do anything with your keys unless you physically touch the token. But out of the box, this is only useful for SSH keys – you can’t do anything else with this support.

Well, that’s what I thought, at least. And then I looked at the code and realised that SSH is communicating with the security tokens using the same library that a browser would, except it ensures that any signature request starts with the string “ssh:” (which a genuine WebAuthn request never will). This constraint can actually be disabled by passing -O no-restrict-websafe to ssh-agent, except that was broken until this weekend. But let’s assume there’s a glorious future where that patch gets backported everywhere, and see what we can do with it.

First we need to load the key into the security token. For this I ended up hacking up the Go SSH agent support. Annoyingly it doesn’t seem to be possible to make calls to the agent without going via one of the exported methods here, so I don’t think this logic can be implemented without modifying the agent module itself. But this is basically as simple as adding another key message type that looks something like:

type ecdsaSkKeyMsg struct {
       Type        string `sshtype:"17|25"`
       Curve       string
       PubKeyBytes []byte
       RpId        string
       Flags       uint8
       KeyHandle   []byte
       Reserved    []byte
       Comments    string
       Constraints []byte `ssh:"rest"`
}

Where Type is ssh.KeyAlgoSKECDSA256, Curve is “nistp256”, RpId is the identity of the relying party (eg, “webauthn.io”), Flags is 0x1 if you want the user to have to touch the key, KeyHandle is the hardware token’s representation of the key (basically an opaque blob that’s sufficient for the token to regenerate the keypair – this is generally stored by the remote site and handed back to you when it wants you to authenticate). The other fields can be ignored, other than PubKeyBytes, which is supposed to be the public half of the keypair.

This causes an obvious problem. We have an opaque blob that represents a keypair. We don’t have the public key. And OpenSSH verifies that PubKeyByes is a legitimate ecdsa public key before it’ll load the key. Fortunately it only verifies that it’s a legitimate ecdsa public key, and does nothing to verify that it’s related to the private key in any way. So, just generate a new ECDSA key (ecdsa.GenerateKey(elliptic.P256(), rand.Reader)) and marshal it ( elliptic.Marshal(ecKey.Curve, ecKey.X, ecKey.Y)) and we’re good. Pass that struct to ssh.Marshal() and then make an agent call.

Now you can use the standard agent interfaces to trigger a signature event. You want to pass the raw challenge (not the hash of the challenge!) – the SSH code will do the hashing itself. If you’re using agent forwarding this will be forwarded from the remote system to your local one, and your security token should start blinking – touch it and you’ll get back an ssh.Signature blob. ssh.Unmarshal() the Blob member to a struct like

type ecSig struct {
        R *big.Int
        S *big.Int
}

and then ssh.Unmarshal the Rest member to

type authData struct {
        Flags    uint8
        SigCount uint32
}

The signature needs to be converted back to a DER-encoded ASN.1 structure (eg,

var b cryptobyte.Builder
b.AddASN1(asn1.SEQUENCE, func(b *cryptobyte.Builder) {
        b.AddASN1BigInt(ecSig.R)
        b.AddASN1BigInt(ecSig.S)
})
signatureDER, _ := b.Bytes()

, and then you need to construct the Authenticator Data structure. For this, take the RpId used earlier and generate the sha256. Append the one byte Flags variable, and then convert SigCount to big endian and append those 4 bytes. You should now have a 37 byte structure. This needs to be CBOR encoded (I used github.com/fxamacker/cbor and just called cbor.Marshal(data, cbor.EncOptions{})).

Now base64 encode the sha256 of the challenge data, the DER-encoded signature and the CBOR-encoded authenticator data and you’ve got everything you need to provide to the remote site to satisfy the challenge.

There are alternative approaches – you can use USB/IP to forward the hardware token directly to the remote system. But that means you can’t use it locally, so it’s less than ideal. Or you could implement a proxy that communicates with the key locally and have that tunneled through to the remote host, but at that point you’re just reinventing ssh-agent.

And you should bear in mind that the default behaviour of blocking this sort of request is for a good reason! If someone is able to compromise a remote system that you’re SSHed into, they can potentially trick you into hitting the key to sign a request they’ve made on behalf of an arbitrary site. Obviously they could do the same without any of this if they’ve compromised your local system, but there is some additional risk to this. It would be nice to have sensible MAC policies that default-denied access to the SSH agent socket and only allowed trustworthy binaries to do so, or maybe have some sort of reasonable flatpak-style portal to gate access. For my threat model I think it’s a worthwhile security tradeoff, but you should evaluate that carefully yourself.

Anyway. Now to figure out whether there’s a reasonable way to get browsers to work with this.

comments